From c6a130673d90dd900ec47ef3302a1f35a1884402 Mon Sep 17 00:00:00 2001 From: ospab Date: Sat, 18 Jul 2026 16:30:44 +0300 Subject: [PATCH] fix(gui): remove duplicate junk/tcp-frag fields from the profile editor modal These were editable in two disconnected places: the profile editor modal (pm-* fields, written into each saved profile's own tcp_fragmentation/ frag_chunk/frag_sleep/junk_pc/junk_ps) and the simple settings page (cs-* fields, a global override applied at connect time via buildConfig()'s merge: `s.tcpFrag || active.tcp_fragmentation`, etc). The simple settings page already covers the same knobs, so the modal copy was pure duplication and a source of confusion about which one actually took effect. Removed the pm-tcp-settings panel and its fields from index.html, and all now-dead JS: the variable lookups, the open-editor populate/reset logic, the save-profile field writes (existing profiles keep their previously- saved values via the {...profiles[idx], ...} merge - only new edits through this modal no longer touch these fields), and the two change listeners whose sole job was showing/hiding the removed panel. The Transport (UDP/UoT) dropdown itself is untouched. --- ostp-gui/src/index.html | 49 ----------------------------------------- ostp-gui/src/main.js | 41 ---------------------------------- 2 files changed, 90 deletions(-) diff --git a/ostp-gui/src/index.html b/ostp-gui/src/index.html index cffeffb..a60e6cf 100644 --- a/ostp-gui/src/index.html +++ b/ostp-gui/src/index.html @@ -402,55 +402,6 @@ - - -
diff --git a/ostp-gui/src/main.js b/ostp-gui/src/main.js index b5e8338..6722974 100644 --- a/ostp-gui/src/main.js +++ b/ostp-gui/src/main.js @@ -113,15 +113,6 @@ const pmName = $('pm-name'); const pmServer = $('pm-server'); const pmKey = $('pm-key'); const pmTransport = $('pm-transport'); -const pmTcpFrag = $('pm-tcp-frag'); -const pmFragChunk = $('pm-frag-chunk'); -const pmFragSleep = $('pm-frag-sleep'); -const pmJunkPcMin = $('pm-junk-pc-min'); -const pmJunkPcMax = $('pm-junk-pc-max'); -const pmJunkPsMin = $('pm-junk-ps-min'); -const pmJunkPsMax = $('pm-junk-ps-max'); -const pmTcpSettings = $('pm-tcp-settings'); -const pmFragDetails = $('pm-frag-details'); const btnProfileCancel = $('btn-profile-cancel'); const btnProfileSave = $('btn-profile-save'); const btnProfileDelete = $('btn-profile-delete'); @@ -522,31 +513,15 @@ function openProfileEditor(id) { pmServer.value = p.server || ''; pmKey.value = p.key || ''; pmTransport.value = p.transport || 'udp'; - pmTcpFrag.checked = !!p.tcp_fragmentation; - pmFragChunk.value = p.frag_chunk || 2; - pmFragSleep.value = p.frag_sleep || 2; - pmJunkPcMin.value = p.junk_pc ? p.junk_pc[0] : 2; - pmJunkPcMax.value = p.junk_pc ? p.junk_pc[1] : 5; - pmJunkPsMin.value = p.junk_ps ? p.junk_ps[0] : 100; - pmJunkPsMax.value = p.junk_ps ? p.junk_ps[1] : 1000; btnProfileDelete.style.display = ''; } else { profileModalTitle.textContent = 'New Profile'; pmName.value = pmServer.value = pmKey.value = ''; pmTransport.value = 'udp'; - pmTcpFrag.checked = false; - pmFragChunk.value = 2; - pmFragSleep.value = 2; - pmJunkPcMin.value = 2; - pmJunkPcMax.value = 5; - pmJunkPsMin.value = 100; - pmJunkPsMax.value = 1000; btnProfileDelete.style.display = 'none'; } pmKey.type = 'password'; profileModal.classList.remove('hidden'); - pmTransport.dispatchEvent(new Event('change')); - pmTcpFrag.dispatchEvent(new Event('change')); setTimeout(() => pmName.focus(), 80); } @@ -564,11 +539,6 @@ function saveProfileFromEditor() { server, key, transport: pmTransport.value, - tcp_fragmentation: pmTcpFrag.checked, - frag_chunk: parseInt(pmFragChunk.value) || 2, - frag_sleep: parseInt(pmFragSleep.value) || 2, - junk_pc: [parseInt(pmJunkPcMin.value)||2, parseInt(pmJunkPcMax.value)||5], - junk_ps: [parseInt(pmJunkPsMin.value)||100, parseInt(pmJunkPsMax.value)||1000], }; } } else { @@ -578,11 +548,6 @@ function saveProfileFromEditor() { server, key, transport: pmTransport.value, - tcp_fragmentation: pmTcpFrag.checked, - frag_chunk: parseInt(pmFragChunk.value) || 2, - frag_sleep: parseInt(pmFragSleep.value) || 2, - junk_pc: [parseInt(pmJunkPcMin.value)||2, parseInt(pmJunkPcMax.value)||5], - junk_ps: [parseInt(pmJunkPsMin.value)||100, parseInt(pmJunkPsMax.value)||1000], }; profiles.push(p); if (!activeId) { activeId = p.id; saveActiveId(activeId); } @@ -875,12 +840,6 @@ window.addEventListener('DOMContentLoaded', async () => { btnProfileCancel.addEventListener('click', () => profileModal.classList.add('hidden')); btnProfileSave.addEventListener('click', saveProfileFromEditor); btnProfileDelete.addEventListener('click', deleteEditingProfile); - pmTransport.addEventListener('change', () => { - pmTcpSettings.style.display = pmTransport.value === 'uot' ? 'block' : 'none'; - }); - pmTcpFrag.addEventListener('change', () => { - pmFragDetails.style.display = pmTcpFrag.checked ? 'block' : 'none'; - }); btnPeekPm.addEventListener('click', () => { pmKey.type = pmKey.type === 'password' ? 'text' : 'password'; });