mirror of https://github.com/ospab/ostp.git
ci: fix run-name to say "channel" instead of a bare branch name
run-name showed "release version nightly" / "release version pre-release" for every branch-push run — read exactly like the release TAG was bare "nightly"/"pre-release" (the bug fixed earlier), when the actual GH Release tag has been correctly versioned (e.g. "0.4.3-nightly") all along via resolve-channel. run-name can't reference job outputs (it's evaluated before any job runs), so it can't show the real computed tag directly — spell out "channel" instead so the label can't be mistaken for the release tag again.
This commit is contained in:
parent
ec947ec9d1
commit
b17e5499eb
|
|
@ -1,6 +1,14 @@
|
||||||
name: CI/CD
|
name: CI/CD
|
||||||
|
|
||||||
run-name: "CI/CD: release version ${{ github.ref_name }}"
|
|
||||||
|
# `run-name` is evaluated at workflow-start, BEFORE any job runs — it cannot
|
||||||
|
# see resolve-channel's computed tag_name (e.g. "0.4.3-nightly"), only the
|
||||||
|
# `github.*` context. The old "release version ${{ github.ref_name }}" showed
|
||||||
|
# the bare branch name ("nightly"/"pre-release") for every run, which reads
|
||||||
|
# exactly like a literal release tag and caused real confusion — the actual
|
||||||
|
# release tag has been correct (versioned) all along; only this label lied
|
||||||
|
# about it. Spell out "channel" so nobody mistakes one for the other again.
|
||||||
|
run-name: ${{ startsWith(github.ref, 'refs/tags/') && format('Release build: {0}', github.ref_name) || format('Release build: {0} channel', github.ref_name) }}
|
||||||
|
|
||||||
on:
|
on:
|
||||||
push:
|
push:
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue